From e473acf11fa5fe8b656c05a79505d8def8dc9fc5 Mon Sep 17 00:00:00 2001
From: moluzhui <44611938+moluzhui@users.noreply.github.com>
Date: Wed, 14 Dec 2022 09:41:08 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20fix=20a=20bug=20that=20faild=20to=20sync?=
 =?UTF-8?q?hronize=20using=20scan=20mode=20when=20source=20=E2=80=A6=20(#5?=
 =?UTF-8?q?47)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: fix a bug that faild to synchronize using scan mode when source is cluster mode

Add type determination for source redis server in scan mode.
When server is in cluster mode, only scan db 0.

* docs: update README

Co-authored-by: root <root@10.86.40.217>
---
 README.md                      |  2 +-
 internal/reader/scan_reader.go | 25 +++++++++++++++++++++++--
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 3418bcc..ee713ad 100644
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@ redis-shake is a tool for Redis data migration and data filtering.
 * ✅ Tested on Redis 5.0, Redis 6.0 and Redis 7.0
 * 🤗 Support custom filtering rules
 * 💪 Support large instance migration
-* 💖 Support `restore` mode and `sync` mode
+* 💖 Support `restore` mode, `sync` mode and `scan` mode
 * ☁️ Support Aliyun Redis and ElastiCache
 
 For older versions of redis-shake (support codis, twemproxy) please
diff --git a/internal/reader/scan_reader.go b/internal/reader/scan_reader.go
index 516f275..bb11e31 100644
--- a/internal/reader/scan_reader.go
+++ b/internal/reader/scan_reader.go
@@ -1,12 +1,19 @@
 package reader
 
 import (
+	"strconv"
+	"strings"
+
 	"github.com/alibaba/RedisShake/internal/client"
 	"github.com/alibaba/RedisShake/internal/client/proto"
 	"github.com/alibaba/RedisShake/internal/entry"
 	"github.com/alibaba/RedisShake/internal/log"
 	"github.com/alibaba/RedisShake/internal/statistics"
-	"strconv"
+)
+
+const (
+	// cluster_enabled: Indicate Redis cluster is enabled. reference from https://redis.io/commands/info/
+	clusterMode = "cluster_enabled:1"
 )
 
 type dbKey struct {
@@ -21,6 +28,7 @@ type scanReader struct {
 	// client for scan keys
 	clientScan   *client.Redis
 	innerChannel chan *dbKey
+	isCluster    bool
 
 	// client for dump keys
 	clientDump     *client.Redis
@@ -34,9 +42,17 @@ func NewScanReader(address string, username string, password string, isTls bool)
 	r.clientScan = client.NewRedisClient(address, username, password, isTls)
 	r.clientDump = client.NewRedisClient(address, username, password, isTls)
 	log.Infof("scanReader connected to redis successful. address=[%s]", address)
+
+	r.isCluster = r.IsCluster()
 	return r
 }
 
+// IsCluster is for determining whether the server is in cluster mode.
+func (r *scanReader) IsCluster() bool {
+	reply := r.clientScan.DoWithStringReply("INFO", "Cluster")
+	return strings.Contains(reply, clusterMode)
+}
+
 func (r *scanReader) StartRead() chan *entry.Entry {
 	r.ch = make(chan *entry.Entry, 1024)
 	r.innerChannel = make(chan *dbKey, 1024)
@@ -46,7 +62,12 @@ func (r *scanReader) StartRead() chan *entry.Entry {
 }
 
 func (r *scanReader) scan() {
-	for dbId := 0; dbId < 16; dbId++ {
+	scanDbIdUpper := 15
+	if r.isCluster {
+		log.Infof("scanReader node are in cluster mode, only scan db 0")
+		scanDbIdUpper = 0
+	}
+	for dbId := 0; dbId <= scanDbIdUpper; dbId++ {
 		var cursor uint64 = 0
 
 		reply := r.clientScan.DoWithStringReply("SELECT", strconv.Itoa(dbId))