From 2135e70f365b139a8e1a0ad89374bd6051b1c7a8 Mon Sep 17 00:00:00 2001 From: Juergen Hoeller Date: Wed, 18 Feb 2015 17:59:32 +0100 Subject: [PATCH] Polishing --- .../java/org/springframework/web/util/WebUtils.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/web/util/WebUtils.java b/spring-web/src/main/java/org/springframework/web/util/WebUtils.java index 61cd603c6e..2821b5e2fb 100644 --- a/spring-web/src/main/java/org/springframework/web/util/WebUtils.java +++ b/spring-web/src/main/java/org/springframework/web/util/WebUtils.java @@ -18,8 +18,8 @@ package org.springframework.web.util; import java.io.File; import java.io.FileNotFoundException; +import java.util.Collection; import java.util.Enumeration; -import java.util.List; import java.util.Map; import java.util.StringTokenizer; import java.util.TreeMap; @@ -33,7 +33,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; -import org.springframework.http.server.ServerHttpRequest; +import org.springframework.http.HttpRequest; import org.springframework.util.Assert; import org.springframework.util.LinkedMultiValueMap; import org.springframework.util.MultiValueMap; @@ -742,9 +742,9 @@ public abstract class WebUtils { * like this {@code "q1=a;q1=b;q2=a,b,c"}. The resulting map would contain * keys {@code "q1"} and {@code "q2"} with values {@code ["a","b"]} and * {@code ["a","b","c"]} respectively. - * * @param matrixVariables the unparsed matrix variables string * @return a map with matrix variable names and values, never {@code null} + * @since 3.2 */ public static MultiValueMap parseMatrixVariables(String matrixVariables) { MultiValueMap result = new LinkedMultiValueMap(); @@ -773,12 +773,11 @@ public abstract class WebUtils { * Check the given request origin against a list of allowed origins. * A list containing "*" means that all origins are allowed. * An empty list means only same origin is allowed. - * * @return true if the request origin is valid, false otherwise * @since 4.1.5 * @see RFC 6454: The Web Origin Concept */ - public static boolean isValidOrigin(ServerHttpRequest request, List allowedOrigins) { + public static boolean isValidOrigin(HttpRequest request, Collection allowedOrigins) { Assert.notNull(request, "Request must not be null"); Assert.notNull(allowedOrigins, "Allowed origins must not be null"); @@ -791,7 +790,7 @@ public abstract class WebUtils { UriComponents requestComponents = UriComponentsBuilder.fromHttpRequest(request).build(); int originPort = getPort(originComponents); int requestPort = getPort(requestComponents); - return originComponents.getHost().equals(requestComponents.getHost()) && (originPort == requestPort); + return (originComponents.getHost().equals(requestComponents.getHost()) && originPort == requestPort); } else { return allowedOrigins.contains(origin);