From 59ef34d769ecb1dd6d2e155af74b79a56d0cb9cc Mon Sep 17 00:00:00 2001 From: Juergen Hoeller Date: Tue, 14 May 2013 21:20:24 +0200 Subject: [PATCH] Polishing --- .../aspectj/AspectJWeaverMessageHandler.java | 26 +++++++++---------- .../AbstractAutowireCapableBeanFactory.java | 5 +--- 2 files changed, 13 insertions(+), 18 deletions(-) diff --git a/spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJWeaverMessageHandler.java b/spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJWeaverMessageHandler.java index 58d3958ec8..25d5cca32b 100644 --- a/spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJWeaverMessageHandler.java +++ b/spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJWeaverMessageHandler.java @@ -45,44 +45,42 @@ public class AspectJWeaverMessageHandler implements IMessageHandler { private static final String AJ_ID = "[AspectJ] "; - private static final Log LOGGER = LogFactory.getLog("AspectJ Weaver"); + private static final Log logger = LogFactory.getLog("AspectJ Weaver"); @Override public boolean handleMessage(IMessage message) throws AbortException { Kind messageKind = message.getKind(); - if (messageKind == IMessage.DEBUG) { - if (LOGGER.isDebugEnabled() || LOGGER.isTraceEnabled()) { - LOGGER.debug(makeMessageFor(message)); + if (logger.isDebugEnabled()) { + logger.debug(makeMessageFor(message)); return true; } } - else if ((messageKind == IMessage.INFO) || (messageKind == IMessage.WEAVEINFO)) { - if (LOGGER.isInfoEnabled()) { - LOGGER.info(makeMessageFor(message)); + else if (messageKind == IMessage.INFO || messageKind == IMessage.WEAVEINFO) { + if (logger.isInfoEnabled()) { + logger.info(makeMessageFor(message)); return true; } } else if (messageKind == IMessage.WARNING) { - if (LOGGER.isWarnEnabled()) { - LOGGER.warn(makeMessageFor(message)); + if (logger.isWarnEnabled()) { + logger.warn(makeMessageFor(message)); return true; } } else if (messageKind == IMessage.ERROR) { - if (LOGGER.isErrorEnabled()) { - LOGGER.error(makeMessageFor(message)); + if (logger.isErrorEnabled()) { + logger.error(makeMessageFor(message)); return true; } } else if (messageKind == IMessage.ABORT) { - if (LOGGER.isFatalEnabled()) { - LOGGER.fatal(makeMessageFor(message)); + if (logger.isFatalEnabled()) { + logger.fatal(makeMessageFor(message)); return true; } } - return false; } diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java index a5badd7c54..b9694d3cf9 100644 --- a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java +++ b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java @@ -171,6 +171,7 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac setParentBeanFactory(parentBeanFactory); } + /** * Set the instantiation strategy to use for creating bean instances. * Default is CglibSubclassingInstantiationStrategy. @@ -261,7 +262,6 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac this.ignoredDependencyInterfaces.add(ifc); } - @Override public void copyConfigurationFrom(ConfigurableBeanFactory otherFactory) { super.copyConfigurationFrom(otherFactory); @@ -352,10 +352,8 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac else { Object bean; final BeanFactory parent = this; - if (System.getSecurityManager() != null) { bean = AccessController.doPrivileged(new PrivilegedAction() { - @Override public Object run() { return getInstantiationStrategy().instantiate(bd, null, parent); @@ -365,7 +363,6 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac else { bean = getInstantiationStrategy().instantiate(bd, null, parent); } - populateBean(beanClass.getName(), bd, new BeanWrapperImpl(bean)); return bean; }