diff --git a/spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java b/spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java index a25ae12b4d..2c2f1569c1 100644 --- a/spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java +++ b/spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java @@ -456,7 +456,8 @@ class ConfigurationClassParser { ImportSelector selector = BeanUtils.instantiateClass(candidateClass, ImportSelector.class); invokeAwareMethods(selector); if (!deferred && selector instanceof DeferredImportSelector) { - this.deferredImportSelectors.add(new DeferredImportSelectorHolder(configClass, (DeferredImportSelector) selector)); + this.deferredImportSelectors.add( + new DeferredImportSelectorHolder(configClass, (DeferredImportSelector) selector)); } else { String[] importClassNames = selector.selectImports(currentSourceClass.getMetadata()); @@ -465,15 +466,19 @@ class ConfigurationClassParser { } } else if (candidate.isAssignable(ImportBeanDefinitionRegistrar.class)) { - // Candidate class is an ImportBeanDefinitionRegistrar -> delegate to it to register additional bean definitions + // Candidate class is an ImportBeanDefinitionRegistrar -> + // delegate to it to register additional bean definitions Class candidateClass = candidate.loadClass(); - ImportBeanDefinitionRegistrar registrar = BeanUtils.instantiateClass(candidateClass, ImportBeanDefinitionRegistrar.class); + ImportBeanDefinitionRegistrar registrar = + BeanUtils.instantiateClass(candidateClass, ImportBeanDefinitionRegistrar.class); invokeAwareMethods(registrar); configClass.addImportBeanDefinitionRegistrar(registrar, currentSourceClass.getMetadata()); } else { - // Candidate class not an ImportSelector or ImportBeanDefinitionRegistrar -> process it as a @Configuration class - this.importStack.registerImport(currentSourceClass.getMetadata(), candidate.getMetadata().getClassName()); + // Candidate class not an ImportSelector or ImportBeanDefinitionRegistrar -> + // process it as a @Configuration class + this.importStack.registerImport( + currentSourceClass.getMetadata(), candidate.getMetadata().getClassName()); processConfigurationClass(candidate.asConfigClass(configClass)); } } @@ -678,12 +683,12 @@ class ConfigurationClassParser { /** - * Simple wrapper that allows annotated source classes to be dealt with in a uniform - * manor, regardless of how they are loaded. + * Simple wrapper that allows annotated source classes to be dealt with + * in a uniform manner, regardless of how they are loaded. */ private class SourceClass { - private final Object source; // Class or MetaDataReader + private final Object source; // Class or MetadataReader private final AnnotationMetadata metadata; diff --git a/spring-context/src/test/java/org/springframework/context/annotation/spr12334/Spr12334Tests.java b/spring-context/src/test/java/org/springframework/context/annotation/spr12334/Spr12334Tests.java index 56e7a3d8b2..c98fc07738 100644 --- a/spring-context/src/test/java/org/springframework/context/annotation/spr12334/Spr12334Tests.java +++ b/spring-context/src/test/java/org/springframework/context/annotation/spr12334/Spr12334Tests.java @@ -33,6 +33,8 @@ public class Spr12334Tests { @Test public void shouldNotScanTwice() { + TestImport.scanned = false; + AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); context.scan(TestImport.class.getPackage().getName()); context.refresh(); @@ -53,14 +55,14 @@ public class Spr12334Tests { public static class TestImport implements ImportBeanDefinitionRegistrar { - private boolean scanned = false; + private static boolean scanned = false; @Override public void registerBeanDefinitions(AnnotationMetadata metadata, BeanDefinitionRegistry registry) { - if (this.scanned) { + if (scanned) { throw new IllegalStateException("Already scanned"); } - this.scanned = true; + scanned = true; } }