ReflectionTestUtils.setField() implicitly calls toString() on the target object when arguments for a call to Assert.notNull() are built. This can have undesirable side effects, for example if the toString() invocation results in a thrown exception or access to an external system (e.g., a database). This commit addresses this issue by inlining the Assert.notNull() code, thereby avoiding accidental invocation of toString() on a non-null target. Issue: SPR-9571master
parent
5710cf5ed2
commit
df961a938e
3 changed files with 72 additions and 11 deletions
@ -0,0 +1,45 @@ |
||||
/* |
||||
* Copyright 2002-2012 the original author or authors. |
||||
* |
||||
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||
* you may not use this file except in compliance with the License. |
||||
* You may obtain a copy of the License at |
||||
* |
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
* |
||||
* Unless required by applicable law or agreed to in writing, software |
||||
* distributed under the License is distributed on an "AS IS" BASIS, |
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||
* See the License for the specific language governing permissions and |
||||
* limitations under the License. |
||||
*/ |
||||
|
||||
package org.springframework.test.util.subpackage; |
||||
|
||||
import org.springframework.core.style.ToStringCreator; |
||||
|
||||
/** |
||||
* A <em>legacy entity</em> whose {@link #toString()} method has side effects; |
||||
* intended for use in unit tests. |
||||
* |
||||
* @author Sam Brannen |
||||
* @since 3.2 |
||||
*/ |
||||
public class LegacyEntity { |
||||
|
||||
private Object collaborator = new Object() { |
||||
|
||||
public String toString() { |
||||
throw new RuntimeException( |
||||
"Invoking toString() on the default collaborator causes an undesirable side effect"); |
||||
}; |
||||
}; |
||||
|
||||
|
||||
public String toString() { |
||||
return new ToStringCreator(this)//
|
||||
.append("collaborator", this.collaborator)//
|
||||
.toString(); |
||||
} |
||||
|
||||
} |
Loading…
Reference in new issue