From f0d28f4b09015f7f61adb4c0f8963d4d41243cdf Mon Sep 17 00:00:00 2001 From: Stephane Maldini Date: Fri, 6 May 2016 23:51:47 +0100 Subject: [PATCH] fixme : force retain() on incoming bytebuf content --- .../http/server/reactive/ReactorServerHttpRequest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-web-reactive/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java b/spring-web-reactive/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java index ba52096395..da38767324 100644 --- a/spring-web-reactive/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java +++ b/spring-web-reactive/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java @@ -17,14 +17,12 @@ package org.springframework.http.server.reactive; import java.net.URI; import java.net.URISyntaxException; -import java.nio.ByteBuffer; import io.netty.handler.codec.http.cookie.Cookie; import reactor.core.publisher.Flux; import reactor.io.netty.http.HttpChannel; import org.springframework.core.io.buffer.DataBuffer; -import org.springframework.core.io.buffer.DataBufferAllocator; import org.springframework.core.io.buffer.NettyDataBufferAllocator; import org.springframework.http.HttpCookie; import org.springframework.http.HttpHeaders; @@ -90,7 +88,9 @@ public class ReactorServerHttpRequest extends AbstractServerHttpRequest { @Override public Flux getBody() { - return this.channel.receive().map(allocator::wrap); + return this.channel.receive() + .retain() //FIXME Rogue reference holding + .map(allocator::wrap); } }