Add InternalServerErrorExceptionHandler

master
Rossen Stoyanchev 9 years ago
parent f2cd92a243
commit 1b3289d0d5
  1. 36
      spring-web-reactive/src/main/java/org/springframework/http/server/reactive/InternalServerErrorExceptionHandler.java
  2. 23
      spring-web-reactive/src/test/java/org/springframework/http/server/reactive/ErrorHandlingHttpHandlerTests.java

@ -0,0 +1,36 @@
/*
* Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.http.server.reactive;
import org.reactivestreams.Publisher;
import org.springframework.http.HttpStatus;
/**
* Handle any exception by setting the response status to 500.
*
* @author Rossen Stoyanchev
*/
public class InternalServerErrorExceptionHandler implements HttpExceptionHandler {
@Override
public Publisher<Void> handle(ServerHttpRequest request, ServerHttpResponse response, Throwable ex) {
response.setStatusCode(HttpStatus.INTERNAL_SERVER_ERROR);
return response.writeHeaders();
}
}

@ -31,7 +31,6 @@ import org.springframework.http.HttpStatus;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
/** /**
* @author Rossen Stoyanchev * @author Rossen Stoyanchev
@ -53,7 +52,7 @@ public class ErrorHandlingHttpHandlerTests {
@Test @Test
public void handleErrorSignal() throws Exception { public void handleErrorSignal() throws Exception {
HttpExceptionHandler exceptionHandler = new HttpStatusExceptionHandler(HttpStatus.INTERNAL_SERVER_ERROR); HttpExceptionHandler exceptionHandler = new InternalServerErrorExceptionHandler();
HttpHandler targetHandler = new TestHttpHandler(new IllegalStateException("boo")); HttpHandler targetHandler = new TestHttpHandler(new IllegalStateException("boo"));
HttpHandler handler = new ErrorHandlingHttpHandler(targetHandler, exceptionHandler); HttpHandler handler = new ErrorHandlingHttpHandler(targetHandler, exceptionHandler);
@ -68,7 +67,7 @@ public class ErrorHandlingHttpHandlerTests {
HttpExceptionHandler[] exceptionHandlers = new HttpExceptionHandler[] { HttpExceptionHandler[] exceptionHandlers = new HttpExceptionHandler[] {
new UnresolvedExceptionHandler(), new UnresolvedExceptionHandler(),
new UnresolvedExceptionHandler(), new UnresolvedExceptionHandler(),
new HttpStatusExceptionHandler(HttpStatus.INTERNAL_SERVER_ERROR), new InternalServerErrorExceptionHandler(),
new UnresolvedExceptionHandler() new UnresolvedExceptionHandler()
}; };
HttpHandler targetHandler = new TestHttpHandler(new IllegalStateException("boo")); HttpHandler targetHandler = new TestHttpHandler(new IllegalStateException("boo"));
@ -95,7 +94,7 @@ public class ErrorHandlingHttpHandlerTests {
@Test @Test
public void thrownExceptionBecomesErrorSignal() throws Exception { public void thrownExceptionBecomesErrorSignal() throws Exception {
HttpExceptionHandler exceptionHandler = new HttpStatusExceptionHandler(HttpStatus.INTERNAL_SERVER_ERROR); HttpExceptionHandler exceptionHandler = new InternalServerErrorExceptionHandler();
HttpHandler targetHandler = new TestHttpHandler(new IllegalStateException("boo"), true); HttpHandler targetHandler = new TestHttpHandler(new IllegalStateException("boo"), true);
HttpHandler handler = new ErrorHandlingHttpHandler(targetHandler, exceptionHandler); HttpHandler handler = new ErrorHandlingHttpHandler(targetHandler, exceptionHandler);
@ -148,20 +147,4 @@ public class ErrorHandlingHttpHandlerTests {
} }
} }
/** Set the response status to the given HttpStatus. */
private static class HttpStatusExceptionHandler implements HttpExceptionHandler {
private final HttpStatus status;
public HttpStatusExceptionHandler(HttpStatus status) {
this.status = status;
}
@Override
public Publisher<Void> handle(ServerHttpRequest request, ServerHttpResponse response, Throwable ex) {
response.setStatusCode(this.status);
return Publishers.empty();
}
}
} }

Loading…
Cancel
Save