AbstractBeanFactory.markBeanAsCreated() reliably clears merged bean definition only once

Issue: SPR-14269
master
Juergen Hoeller 8 years ago
parent bff8259fb0
commit 9064d38e4c
  1. 11
      spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanFactory.java

@ -1503,10 +1503,13 @@ public abstract class AbstractBeanFactory extends FactoryBeanRegistrySupport imp
*/ */
protected void markBeanAsCreated(String beanName) { protected void markBeanAsCreated(String beanName) {
if (!this.alreadyCreated.contains(beanName)) { if (!this.alreadyCreated.contains(beanName)) {
// Let the bean definition get re-merged now that we're actually creating synchronized (this.mergedBeanDefinitions) {
// the bean... just in case some of its metadata changed in the meantime. if (this.alreadyCreated.add(beanName)) {
clearMergedBeanDefinition(beanName); // Let the bean definition get re-merged now that we're actually creating
this.alreadyCreated.add(beanName); // the bean... just in case some of its metadata changed in the meantime.
clearMergedBeanDefinition(beanName);
}
}
} }
} }

Loading…
Cancel
Save